ui: Ensure Flame Graph is reset on all toolbar interactions#5953
Merged
Conversation
Now resets flame graph state on filter and group-by changes for improved consistency. Renames useResetStateOnNewSearch to useResetFlameGraphState and updates all references. Removes unused curPath state and related props from visualization and dashboard components.
|
✅ Meticulous spotted 0 visual differences across 472 screens tested: view results. Meticulous evaluated ~5 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 3275509. This comment will update as new commits are pushed. |
yomete
commented
Sep 15, 2025
| profileSource: ProfileSource; | ||
| total: bigint; | ||
| filtered: bigint; | ||
| curPath: string[]; |
Contributor
Author
There was a problem hiding this comment.
Doing some cleanups here as we no longer need these props.
yomete
commented
Sep 15, 2025
|
|
||
| const { | ||
| curPath, | ||
| setCurPath, |
Contributor
Author
There was a problem hiding this comment.
Doing some cleanups here as we no longer need these props.
yomete
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that we now reset the Flame Graph on Filters and Level of Profiling changes. I thought it'd be a good idea to rename the
useResetStateOnNewSearchhook touseResetFlameGraphStatesince that reflects/explains more what happens in the hook.