Add purged state for debuginfo cleanup#6030
Merged
brancz merged 2 commits intoNov 3, 2025
Merged
Conversation
This commit introduces a new STATE_PURGED state to track debuginfo that has been cleaned up from storage. This allows the system to: 1. Signal to users that debuginfo existed but was purged/cleaned up 2. Allow re-uploading of purged debuginfo 3. Prevent symbolization attempts with purged debuginfo Changes: - Add STATE_PURGED enum value to proto definition - Update generated Go and TypeScript code - Add MarkAsPurged method to ObjectStoreMetadata - Handle purged state in ShouldInitiateUpload (allows re-upload) - Handle purged state in symbolizer (returns ErrDebuginfoPurged) - Add ErrDebuginfoPurged error definition
|
✅ Meticulous spotted 0 visual differences across 391 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit e584719. This comment will update as new commits are pushed. |
asubiotto
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new STATE_PURGED state to track debuginfo that has been cleaned up from storage. This allows the system to:
Changes: