Skip to content

Add purged state for debuginfo cleanup#6030

Merged
brancz merged 2 commits into
mainfrom
claude/add-purged-debuginfo-state-011CUkeRi97JMHXKxYqsRo2i
Nov 3, 2025
Merged

Add purged state for debuginfo cleanup#6030
brancz merged 2 commits into
mainfrom
claude/add-purged-debuginfo-state-011CUkeRi97JMHXKxYqsRo2i

Conversation

@brancz
Copy link
Copy Markdown
Member

@brancz brancz commented Nov 3, 2025

This commit introduces a new STATE_PURGED state to track debuginfo that has been cleaned up from storage. This allows the system to:

  1. Signal to users that debuginfo existed but was purged/cleaned up
  2. Allow re-uploading of purged debuginfo
  3. Prevent symbolization attempts with purged debuginfo

Changes:

  • Add STATE_PURGED enum value to proto definition
  • Update generated Go and TypeScript code
  • Add MarkAsPurged method to ObjectStoreMetadata
  • Handle purged state in ShouldInitiateUpload (allows re-upload)
  • Handle purged state in symbolizer (returns ErrDebuginfoPurged)
  • Add ErrDebuginfoPurged error definition

This commit introduces a new STATE_PURGED state to track debuginfo that
has been cleaned up from storage. This allows the system to:

1. Signal to users that debuginfo existed but was purged/cleaned up
2. Allow re-uploading of purged debuginfo
3. Prevent symbolization attempts with purged debuginfo

Changes:
- Add STATE_PURGED enum value to proto definition
- Update generated Go and TypeScript code
- Add MarkAsPurged method to ObjectStoreMetadata
- Handle purged state in ShouldInitiateUpload (allows re-upload)
- Handle purged state in symbolizer (returns ErrDebuginfoPurged)
- Add ErrDebuginfoPurged error definition
@brancz brancz requested review from a team as code owners November 3, 2025 09:38
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 3, 2025

CLA assistant check
All committers have signed the CLA.

@alwaysmeticulous
Copy link
Copy Markdown

alwaysmeticulous Bot commented Nov 3, 2025

✅ Meticulous spotted 0 visual differences across 391 screens tested: view results.

Meticulous evaluated ~4 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit e584719. This comment will update as new commits are pushed.

@brancz brancz merged commit 2332f67 into main Nov 3, 2025
34 of 35 checks passed
@metalmatze metalmatze deleted the claude/add-purged-debuginfo-state-011CUkeRi97JMHXKxYqsRo2i branch November 3, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants