Refactor ProfileSelector and MetricsGraphSection components#6073
Merged
Conversation
Replaces matcher string and query management in UnifiedLabelsContext with useQueryState across MatchersInput, SimpleMatchers, and ViewMatchers. Removes unused props and context values, and updates label value fetching to use ParcaContext. Exports LabelsQueryProviderContextType for type safety.
…ca-dev/parca into refactor-utilization-metrics
|
✅ Meticulous spotted 0 visual differences across 315 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 41cfe21. This comment will update as new commits are pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors ProfileSelector and MetricsGraphSection to remove utilization-specific props and logic
There's also a new LabelsQueryProvider context that is responsible for fetching labels data from the Parca API
and making it available to child components and a UnifiedLabelsProvider context that consolidates raw label arrays into UI-friendly formats and passes it down to components like SimpleMatchers and MatchersInput