ui: Fix focusing on series in the metrics graph#6074
Merged
Conversation
Updated MetricsGraphSection and ProfileSelector to use the commitDraft function for applying label matcher filters from the metrics graph.
|
✅ Meticulous spotted 0 visual differences across 317 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 951c99d. This comment will update as new commits are pushed. |
yomete
commented
Nov 27, 2025
|
|
||
| // Draft setters (update local state only) | ||
| setDraftExpression: (expression: string, commit?: boolean) => void; | ||
| setDraftExpression: (expression: string) => void; |
Contributor
Author
There was a problem hiding this comment.
we never use this commit boolean anywhere so removing it
metalmatze
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the right click menu to focus on a series only added the label matchers but doesn't run the query.
This fixes it by modifying the
MetricsGraphSectionandProfileSelectorto use thecommitDraftfunction for applying label matcher filters essentially triggering a query search.