Add frame filters to exclude async and error handling functions#6196
Merged
Conversation
Add 5 predicates to hide_rust_futures (poll, {closure#, {async_block#,
invoke, {async_fn#) and 3 to hide_rust_panic_backtrace (catch_unwind<,
call_once<, do_call<) to filter out common Rust async/futures and
panic infrastructure frames from profiles.
https://claude.ai/code/session_014AR8EUAyaeqpQuAhb5tEA9
|
✅ Meticulous spotted 0 visual differences across 342 screens tested: view results. Meticulous evaluated ~4 hours of user flows against your PR. Expected differences? Click here. Last updated for commit 8474297. This comment will update as new commits are pushed. |
Add "not contains tokio::runtime" to hide_tokio_frames, and "not equals run", "not starts with try_poll" to hide_rust_futures. Skip "not starts with poll" as it already exists. https://claude.ai/code/session_014AR8EUAyaeqpQuAhb5tEA9
asubiotto
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds additional frame filtering rules to two profile filter presets to exclude common async runtime and error handling functions from profiling views.
Key Changes
Async preset: Added 5 new filters to exclude:
poll(async polling){closure#){async_block#)invokefunction calls{async_fn#)Default preset: Added 3 new filters to exclude:
catch_unwind<(panic catching)call_once<(one-time function calls)do_call<(internal call wrappers)Implementation Details
These filters use the
not_starts_withandnot_equalmatch types on thefunction_namefield to exclude frames that are typically part of the async runtime machinery or error handling infrastructure. This helps reduce noise in profile views by filtering out internal framework functions that are less relevant to application-level performance analysis.https://claude.ai/code/session_014AR8EUAyaeqpQuAhb5tEA9