Skip to content

Revert "chore(deps-dev): bump the vitest group with 4 updates"#7678

Merged
francinelucca merged 1 commit into
mainfrom
revert-7378-dependabot/npm_and_yarn/vitest-d24016cca7
Mar 18, 2026
Merged

Revert "chore(deps-dev): bump the vitest group with 4 updates"#7678
francinelucca merged 1 commit into
mainfrom
revert-7378-dependabot/npm_and_yarn/vitest-d24016cca7

Conversation

@francinelucca
Copy link
Copy Markdown
Member

Reverts #7378

@francinelucca francinelucca requested a review from a team as a code owner March 18, 2026 17:03
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 18, 2026

⚠️ No Changeset found

Latest commit: c7b802f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts #7378, rolling back the recent Vitest-related dev dependency upgrades and restoring the prior test setup expectations in @primer/react.

Changes:

  • Downgrades vitest, @vitest/browser, @vitest/browser-playwright, and @vitest/eslint-plugin back to the previously pinned versions.
  • Reverts TreeView browser test timer configuration back to vi.useFakeTimers() defaults.
  • Updates package-lock.json to reflect the reverted dependency graph.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/TreeView/TreeView.test.tsx Restores the prior fake-timers setup used by the TreeView browser-mode tests.
package.json Reverts Vitest-related devDependency versions back to the pre-#7378 state.
package-lock.json Aligns the lockfile with the reverted dependency versions and transitive deps.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines +1521 to 1522
vi.useFakeTimers()

@francinelucca francinelucca added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 552b970 Mar 18, 2026
68 of 69 checks passed
@francinelucca francinelucca deleted the revert-7378-dependabot/npm_and_yarn/vitest-d24016cca7 branch March 18, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants