Extract formatting tests#1785
Conversation
| pytest-mock >= 3.3.1 | ||
| pytest-cases >= 2.3.0 | ||
| coverage >= 5.3 | ||
| parameterized >= 0.7.4 No newline at end of file |
There was a problem hiding this comment.
Rather then adding a new dependency, can @pytest.mark.parametrize be used to do the same thing?
There was a problem hiding this comment.
It can, but it has been requested specifically to avoid using pytest in tests directly in order to allow people to use the testing platform of their choosing.
I personally prefer using pytest at any time, but I respect the design decisions of this project.
There was a problem hiding this comment.
My main pytest dislike is it's magical patching of thing so I guess the adding of a dep to allow both testing systems to be used works. Especially when this refactor is a big win imo.
|
@cooperlees, any feedback on this? |
cooperlees
left a comment
cooperlees
left a comment
There was a problem hiding this comment.
All looks like a good refactor to me. ~250 less lines and all makes sense! Thanks!
* Update test versions * Use parametrize to remove tests duplications * Extract sources format tests * Fix mypy errors * Fix .travis.yml
3 participants
A lot of the tests in Black are exact duplications of other tests.
In order to remove some of the duplications, added 2 parametrized tests that combine those tests.