Fix blackd error handling: split SourceASTParseError from ASTSafetyError#5080
Merged
Conversation
- Add SourceASTParseError exception for source file AST parse failures (user input issue, not a Black bug) - Keep ASTSafetyError for Black output issues (invalid code, non-equivalent) - In blackd, return 400 for SourceASTParseError, 500 for ASTSafetyError - Per @JelleZijlstra review feedback on #5074
Contributor
Author
|
Hi team, just wanted to follow up on this PR. Would appreciate any feedback! |
Collaborator
|
The code looks good to me, could you just add changelog entries (one in the Output section about the new error, and one in the Blackd section about the corrected handling) and updated tests? |
Collaborator
|
Looks good, but please add a changelog entry. |
Contributor
Author
|
Thanks @cobaltt7 @JelleZijlstra for the review! I will add the changelog entries (Output section for the new error, Blackd section for the corrected handling) and update the tests. Pushing changes shortly. |
Collaborator
|
Thanks! |
luketainton
pushed a commit
to luketainton/repos_webexmemebot
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [black](https://github.com/psf/black) ([changelog](https://github.com/psf/black/blob/main/CHANGES.md)) | `<26.3.2,>=26.3.1` → `<26.5.1,>=26.5.0` |  |  | --- ### Release Notes <details> <summary>psf/black (black)</summary> ### [`v26.5.0`](https://github.com/psf/black/blob/HEAD/CHANGES.md#Version-2650) [Compare Source](psf/black@26.3.1...26.5.0) ##### Highlights - Add support for unpacking in comprehensions (PEP 798) and for lazy imports (PEP 810), both new syntactic features in Python 3.15 ([#​5048](psf/black#5048)) - Python 3.15 is now supported. Compiled wheels are not yet provided for Python 3.15, so performance may be slower than on existing Python versions. Wheels will be provided once Python 3.15 is later in its release cycle. ([#​5127](psf/black#5127)) ##### Stable style - Fix `# fmt: skip` being ignored in nested `if` expressions with parenthesized `in` clauses ([#​4903](psf/black#4903)) - Add syntactic support for Python 3.15 ([#​5048](psf/black#5048)) - Fix crash when an f-string follows a `# fmt: off` comment inside brackets ([#​5097](psf/black#5097)) - Preserve multiline compound statement headers when `# fmt: skip` is placed on the colon line ([#​5117](psf/black#5117)) ##### Preview style - Improve heuristics around whether blank lines should appear before, within and after groups of same-name decorated functions (such as `@overload` groups) in `.pyi` stub files ([#​5021](psf/black#5021)) - Fix blank lines being removed between a function and a decorated class in `.pyi` stub files ([#​5092](psf/black#5092)) - Prevent string merger from creating unsplittable long lines when a pragma comment (e.g. `# type: ignore`) follows the closing bracket ([#​5096](psf/black#5096)) ##### Packaging - Run CI on 3.15 ([#​5127](psf/black#5127)) ##### Output - Improve parse error readability by showing multi-line output with an error pointer. ([#​5068](psf/black#5068)) - Add `SourceASTParseError` to distinguish source parse failures from internal safety errors, improving error reporting when Black's lenient parser accepts input that `ast.parse()` rejects ([#​5080](psf/black#5080)) ##### *Blackd* - Return HTTP 400 (Bad Request) for source parse failures instead of HTTP 500, keeping HTTP 500 only for genuine internal safety errors ([#​5080](psf/black#5080)) ##### Integrations - Added documentation for doctest formatting tools and updated the integrations index to match ([#​4916](psf/black#4916)) ##### Documentation - Use "Version X.Y.Z" headings in changelog for stable permalink anchors on ReadTheDocs ([#​5063](psf/black#5063)) - Note in the editor integrations that the SublimeText `sublack` plugin is archived and unmaintained ([#​5082](psf/black#5082)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODEuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/webexmemebot/pulls/585 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_PwnedPW
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [black](https://github.com/psf/black) ([changelog](https://github.com/psf/black/blob/main/CHANGES.md)) | `<26.3.2,>=26.3.1` → `<26.5.1,>=26.5.0` |  |  | --- ### Release Notes <details> <summary>psf/black (black)</summary> ### [`v26.5.0`](https://github.com/psf/black/blob/HEAD/CHANGES.md#Version-2650) [Compare Source](psf/black@26.3.1...26.5.0) ##### Highlights - Add support for unpacking in comprehensions (PEP 798) and for lazy imports (PEP 810), both new syntactic features in Python 3.15 ([#​5048](psf/black#5048)) - Python 3.15 is now supported. Compiled wheels are not yet provided for Python 3.15, so performance may be slower than on existing Python versions. Wheels will be provided once Python 3.15 is later in its release cycle. ([#​5127](psf/black#5127)) ##### Stable style - Fix `# fmt: skip` being ignored in nested `if` expressions with parenthesized `in` clauses ([#​4903](psf/black#4903)) - Add syntactic support for Python 3.15 ([#​5048](psf/black#5048)) - Fix crash when an f-string follows a `# fmt: off` comment inside brackets ([#​5097](psf/black#5097)) - Preserve multiline compound statement headers when `# fmt: skip` is placed on the colon line ([#​5117](psf/black#5117)) ##### Preview style - Improve heuristics around whether blank lines should appear before, within and after groups of same-name decorated functions (such as `@overload` groups) in `.pyi` stub files ([#​5021](psf/black#5021)) - Fix blank lines being removed between a function and a decorated class in `.pyi` stub files ([#​5092](psf/black#5092)) - Prevent string merger from creating unsplittable long lines when a pragma comment (e.g. `# type: ignore`) follows the closing bracket ([#​5096](psf/black#5096)) ##### Packaging - Run CI on 3.15 ([#​5127](psf/black#5127)) ##### Output - Improve parse error readability by showing multi-line output with an error pointer. ([#​5068](psf/black#5068)) - Add `SourceASTParseError` to distinguish source parse failures from internal safety errors, improving error reporting when Black's lenient parser accepts input that `ast.parse()` rejects ([#​5080](psf/black#5080)) ##### *Blackd* - Return HTTP 400 (Bad Request) for source parse failures instead of HTTP 500, keeping HTTP 500 only for genuine internal safety errors ([#​5080](psf/black#5080)) ##### Integrations - Added documentation for doctest formatting tools and updated the integrations index to match ([#​4916](psf/black#4916)) ##### Documentation - Use "Version X.Y.Z" headings in changelog for stable permalink anchors on ReadTheDocs ([#​5063](psf/black#5063)) - Note in the editor integrations that the SublimeText `sublack` plugin is archived and unmaintained ([#​5082](psf/black#5082)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODEuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJsaW50aW5nIl19--> Reviewed-on: https://git.tainton.uk/repos/PwnedPW/pulls/334 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_epage
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [black](https://github.com/psf/black) ([changelog](https://github.com/psf/black/blob/main/CHANGES.md)) | `<26.3.2,>=26.3.1` → `<26.5.1,>=26.5.0` |  |  | --- ### Release Notes <details> <summary>psf/black (black)</summary> ### [`v26.5.0`](https://github.com/psf/black/blob/HEAD/CHANGES.md#Version-2650) [Compare Source](psf/black@26.3.1...26.5.0) ##### Highlights - Add support for unpacking in comprehensions (PEP 798) and for lazy imports (PEP 810), both new syntactic features in Python 3.15 ([#​5048](psf/black#5048)) - Python 3.15 is now supported. Compiled wheels are not yet provided for Python 3.15, so performance may be slower than on existing Python versions. Wheels will be provided once Python 3.15 is later in its release cycle. ([#​5127](psf/black#5127)) ##### Stable style - Fix `# fmt: skip` being ignored in nested `if` expressions with parenthesized `in` clauses ([#​4903](psf/black#4903)) - Add syntactic support for Python 3.15 ([#​5048](psf/black#5048)) - Fix crash when an f-string follows a `# fmt: off` comment inside brackets ([#​5097](psf/black#5097)) - Preserve multiline compound statement headers when `# fmt: skip` is placed on the colon line ([#​5117](psf/black#5117)) ##### Preview style - Improve heuristics around whether blank lines should appear before, within and after groups of same-name decorated functions (such as `@overload` groups) in `.pyi` stub files ([#​5021](psf/black#5021)) - Fix blank lines being removed between a function and a decorated class in `.pyi` stub files ([#​5092](psf/black#5092)) - Prevent string merger from creating unsplittable long lines when a pragma comment (e.g. `# type: ignore`) follows the closing bracket ([#​5096](psf/black#5096)) ##### Packaging - Run CI on 3.15 ([#​5127](psf/black#5127)) ##### Output - Improve parse error readability by showing multi-line output with an error pointer. ([#​5068](psf/black#5068)) - Add `SourceASTParseError` to distinguish source parse failures from internal safety errors, improving error reporting when Black's lenient parser accepts input that `ast.parse()` rejects ([#​5080](psf/black#5080)) ##### *Blackd* - Return HTTP 400 (Bad Request) for source parse failures instead of HTTP 500, keeping HTTP 500 only for genuine internal safety errors ([#​5080](psf/black#5080)) ##### Integrations - Added documentation for doctest formatting tools and updated the integrations index to match ([#​4916](psf/black#4916)) ##### Documentation - Use "Version X.Y.Z" headings in changelog for stable permalink anchors on ReadTheDocs ([#​5063](psf/black#5063)) - Note in the editor integrations that the SublimeText `sublack` plugin is archived and unmaintained ([#​5082](psf/black#5082)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODEuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/epage/pulls/220 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/luke_instant-msg-api
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [black](https://github.com/psf/black) ([changelog](https://github.com/psf/black/blob/main/CHANGES.md)) | `<26.3.2,>=26.3.1` → `<26.5.1,>=26.5.0` |  |  | --- ### Release Notes <details> <summary>psf/black (black)</summary> ### [`v26.5.0`](https://github.com/psf/black/blob/HEAD/CHANGES.md#Version-2650) [Compare Source](psf/black@26.3.1...26.5.0) ##### Highlights - Add support for unpacking in comprehensions (PEP 798) and for lazy imports (PEP 810), both new syntactic features in Python 3.15 ([#​5048](psf/black#5048)) - Python 3.15 is now supported. Compiled wheels are not yet provided for Python 3.15, so performance may be slower than on existing Python versions. Wheels will be provided once Python 3.15 is later in its release cycle. ([#​5127](psf/black#5127)) ##### Stable style - Fix `# fmt: skip` being ignored in nested `if` expressions with parenthesized `in` clauses ([#​4903](psf/black#4903)) - Add syntactic support for Python 3.15 ([#​5048](psf/black#5048)) - Fix crash when an f-string follows a `# fmt: off` comment inside brackets ([#​5097](psf/black#5097)) - Preserve multiline compound statement headers when `# fmt: skip` is placed on the colon line ([#​5117](psf/black#5117)) ##### Preview style - Improve heuristics around whether blank lines should appear before, within and after groups of same-name decorated functions (such as `@overload` groups) in `.pyi` stub files ([#​5021](psf/black#5021)) - Fix blank lines being removed between a function and a decorated class in `.pyi` stub files ([#​5092](psf/black#5092)) - Prevent string merger from creating unsplittable long lines when a pragma comment (e.g. `# type: ignore`) follows the closing bracket ([#​5096](psf/black#5096)) ##### Packaging - Run CI on 3.15 ([#​5127](psf/black#5127)) ##### Output - Improve parse error readability by showing multi-line output with an error pointer. ([#​5068](psf/black#5068)) - Add `SourceASTParseError` to distinguish source parse failures from internal safety errors, improving error reporting when Black's lenient parser accepts input that `ast.parse()` rejects ([#​5080](psf/black#5080)) ##### *Blackd* - Return HTTP 400 (Bad Request) for source parse failures instead of HTTP 500, keeping HTTP 500 only for genuine internal safety errors ([#​5080](psf/black#5080)) ##### Integrations - Added documentation for doctest formatting tools and updated the integrations index to match ([#​4916](psf/black#4916)) ##### Documentation - Use "Version X.Y.Z" headings in changelog for stable permalink anchors on ReadTheDocs ([#​5063](psf/black#5063)) - Note in the editor integrations that the SublimeText `sublack` plugin is archived and unmaintained ([#​5082](psf/black#5082)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODEuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/luke/instant-msg-api/pulls/258 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_pypilot
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [black](https://github.com/psf/black) ([changelog](https://github.com/psf/black/blob/main/CHANGES.md)) | `<26.3.2,>=26.3.1` → `<26.5.1,>=26.5.0` |  |  | --- ### Release Notes <details> <summary>psf/black (black)</summary> ### [`v26.5.0`](https://github.com/psf/black/blob/HEAD/CHANGES.md#Version-2650) [Compare Source](psf/black@26.3.1...26.5.0) ##### Highlights - Add support for unpacking in comprehensions (PEP 798) and for lazy imports (PEP 810), both new syntactic features in Python 3.15 ([#​5048](psf/black#5048)) - Python 3.15 is now supported. Compiled wheels are not yet provided for Python 3.15, so performance may be slower than on existing Python versions. Wheels will be provided once Python 3.15 is later in its release cycle. ([#​5127](psf/black#5127)) ##### Stable style - Fix `# fmt: skip` being ignored in nested `if` expressions with parenthesized `in` clauses ([#​4903](psf/black#4903)) - Add syntactic support for Python 3.15 ([#​5048](psf/black#5048)) - Fix crash when an f-string follows a `# fmt: off` comment inside brackets ([#​5097](psf/black#5097)) - Preserve multiline compound statement headers when `# fmt: skip` is placed on the colon line ([#​5117](psf/black#5117)) ##### Preview style - Improve heuristics around whether blank lines should appear before, within and after groups of same-name decorated functions (such as `@overload` groups) in `.pyi` stub files ([#​5021](psf/black#5021)) - Fix blank lines being removed between a function and a decorated class in `.pyi` stub files ([#​5092](psf/black#5092)) - Prevent string merger from creating unsplittable long lines when a pragma comment (e.g. `# type: ignore`) follows the closing bracket ([#​5096](psf/black#5096)) ##### Packaging - Run CI on 3.15 ([#​5127](psf/black#5127)) ##### Output - Improve parse error readability by showing multi-line output with an error pointer. ([#​5068](psf/black#5068)) - Add `SourceASTParseError` to distinguish source parse failures from internal safety errors, improving error reporting when Black's lenient parser accepts input that `ast.parse()` rejects ([#​5080](psf/black#5080)) ##### *Blackd* - Return HTTP 400 (Bad Request) for source parse failures instead of HTTP 500, keeping HTTP 500 only for genuine internal safety errors ([#​5080](psf/black#5080)) ##### Integrations - Added documentation for doctest formatting tools and updated the integrations index to match ([#​4916](psf/black#4916)) ##### Documentation - Use "Version X.Y.Z" headings in changelog for stable permalink anchors on ReadTheDocs ([#​5063](psf/black#5063)) - Note in the editor integrations that the SublimeText `sublack` plugin is archived and unmaintained ([#​5082](psf/black#5082)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODEuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/pypilot/pulls/446 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
luketainton
pushed a commit
to luketainton/repos_roboluke
that referenced
this pull request
May 17, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [black](https://github.com/psf/black) ([changelog](https://github.com/psf/black/blob/main/CHANGES.md)) | `<26.3.2,>=26.3.1` → `<26.5.1,>=26.5.0` |  |  | --- ### Release Notes <details> <summary>psf/black (black)</summary> ### [`v26.5.0`](https://github.com/psf/black/blob/HEAD/CHANGES.md#Version-2650) [Compare Source](psf/black@26.3.1...26.5.0) ##### Highlights - Add support for unpacking in comprehensions (PEP 798) and for lazy imports (PEP 810), both new syntactic features in Python 3.15 ([#​5048](psf/black#5048)) - Python 3.15 is now supported. Compiled wheels are not yet provided for Python 3.15, so performance may be slower than on existing Python versions. Wheels will be provided once Python 3.15 is later in its release cycle. ([#​5127](psf/black#5127)) ##### Stable style - Fix `# fmt: skip` being ignored in nested `if` expressions with parenthesized `in` clauses ([#​4903](psf/black#4903)) - Add syntactic support for Python 3.15 ([#​5048](psf/black#5048)) - Fix crash when an f-string follows a `# fmt: off` comment inside brackets ([#​5097](psf/black#5097)) - Preserve multiline compound statement headers when `# fmt: skip` is placed on the colon line ([#​5117](psf/black#5117)) ##### Preview style - Improve heuristics around whether blank lines should appear before, within and after groups of same-name decorated functions (such as `@overload` groups) in `.pyi` stub files ([#​5021](psf/black#5021)) - Fix blank lines being removed between a function and a decorated class in `.pyi` stub files ([#​5092](psf/black#5092)) - Prevent string merger from creating unsplittable long lines when a pragma comment (e.g. `# type: ignore`) follows the closing bracket ([#​5096](psf/black#5096)) ##### Packaging - Run CI on 3.15 ([#​5127](psf/black#5127)) ##### Output - Improve parse error readability by showing multi-line output with an error pointer. ([#​5068](psf/black#5068)) - Add `SourceASTParseError` to distinguish source parse failures from internal safety errors, improving error reporting when Black's lenient parser accepts input that `ast.parse()` rejects ([#​5080](psf/black#5080)) ##### *Blackd* - Return HTTP 400 (Bad Request) for source parse failures instead of HTTP 500, keeping HTTP 500 only for genuine internal safety errors ([#​5080](psf/black#5080)) ##### Integrations - Added documentation for doctest formatting tools and updated the integrations index to match ([#​4916](psf/black#4916)) ##### Documentation - Use "Version X.Y.Z" headings in changelog for stable permalink anchors on ReadTheDocs ([#​5063](psf/black#5063)) - Note in the editor integrations that the SublimeText `sublack` plugin is archived and unmaintained ([#​5082](psf/black#5082)) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODEuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL2RlcGVuZGVuY2llcyJdfQ==--> Reviewed-on: https://git.tainton.uk/repos/roboluke/pulls/448 Co-authored-by: renovate[bot] <renovate-bot@git.tainton.uk> Co-committed-by: renovate[bot] <renovate-bot@git.tainton.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @JelleZijlstra's review feedback on #5074, this PR splits the error handling instead of treating all ASTSafetyError as 400.
Changes
New exception:
SourceASTParseError(src/black/parsing.py)ast.parse()but was accepted by Black's more lenient lib2to3 parserUpdated
assert_equivalent(src/black/__init__.py)SourceASTParseError(user input issue)ASTSafetyError(Black bug → 500)ASTSafetyError(Black bug → 500)Updated blackd (
src/blackd/__init__.py)SourceASTParseError→ 400 Bad RequestASTSafetyError→ 500 Internal Server Error (unchanged, caught by generic Exception handler)Closes
Fixes #3616
Analysis of all ASTSafetyError uses
assert_equivalentsrc AST parse failSourceASTParseErrorassert_equivalentdest AST parse failASTSafetyErrorassert_equivalentsrc ≠ dstASTSafetyErrorcheck_stability_and_equivalencere-raise