fix crash with continue in nested try/finally

[nnorwitz]

BPO	1542451
Nosy	@Yhg1s, @arigo, @birkenfeld
Files	finally.diff: v1 (really two :-)

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2007-03-05.08:28:45.000>
created_at = <Date 2006-08-18.07:27:49.000>
labels = ['interpreter-core']
title = 'fix crash with continue in nested try/finally'
updated_at = <Date 2007-03-05.08:28:45.000>
user = 'https://bugs.python.org/nnorwitz'

bugs.python.org fields:

activity = <Date 2007-03-05.08:28:45.000>
actor = 'nnorwitz'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Interpreter Core']
creation = <Date 2006-08-18.07:27:49.000>
creator = 'nnorwitz'
dependencies = []
files = ['7482']
hgrepos = []
issue_num = 1542451
keywords = ['patch']
message_count = 10.0
messages = ['50932', '50933', '50934', '50935', '50936', '50937', '50938', '50939', '50940', '50941']
nosy_count = 5.0
nosy_names = ['twouters', 'nnorwitz', 'arigo', 'georg.brandl', 'complex']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1542451'
versions = ['Python 2.5']

[nnorwitz]

Based on mail from python-dev.

http://mail.python.org/pipermail/python-dev/2006-August/068306.html

def test():
   for abc in range(10):
       try: pass
       finally:
           try:
               continue
           except:
               pass

crashes.

[arigo]

Logged In: YES
user_id=4771

My two cents are a meta-note: I think that this should not go
into 2.5.0. It fixes a bug with syntactically invalid
code, which nobody stumbled upon until recently although
it has been here for ages, and there is a (small) risk to
break syntactically valid code.

[nnorwitz]

Logged In: YES
user_id=33168

I've been thinking similarly. I didn't even update the
import magic for this.

Did you get a chance to review the patch? It would be nice
to get this into 2.6 and then we can figure out if this
should go into 2.5.0 (probably not) or 2.5.1 (probably in my
current thinking), or just leave it for 2.6.

[Yhg1s]

Logged In: YES
user_id=34209

I think we should just check this in in 2.5.0. It looks
fine, it's the simple and correct fix, and I don't see how
it could break legitimate code. It's not a complex piece of
code.

[nnorwitz]

Logged In: YES
user_id=33168

Committed revision 51439. (2.6)

Thomas Wouters thinks this is fine to go in 2.5. I'll leave
open for now until we decide what to do.

[birkenfeld]

Logged In: YES
user_id=849994

Time to checkin for 2.5.1?

[nnorwitz]

Logged In: YES
user_id=33168

Georg, if you don't mind doing this, I think it's fine to go
into 2.5.1. I'll try to get around to it at some point if not.

[birkenfeld]

Logged In: YES
user_id=849994

Committed rev. 52220 in 2.5 branch. Closing now.

[complex]

Example code crashes Python 2.5 (r25:51908, Sep 19 2006, 09:52:17) [MSC v.1310 32 bit (Intel)], but this bug is closed as fixed. Is this OK? (Maybe I missed something, but this bug still exists...)

[nnorwitz]

The bug was fixed after 2.5 was released. The fix is in SVN currently and will be part of the 2.5.1 release.