Skip to content

gh-103363: Add follow_symlinks argument to pathlib.Path.owner() and group()#107962

Merged
barneygale merged 10 commits intopython:mainfrom
kamilturek:gh-103363
Dec 4, 2023
Merged

gh-103363: Add follow_symlinks argument to pathlib.Path.owner() and group()#107962
barneygale merged 10 commits intopython:mainfrom
kamilturek:gh-103363

Conversation

@kamilturek
Copy link
Contributor

@kamilturek kamilturek commented Aug 15, 2023 •
edited by AA-Turner
Loading

@bedevere-bot bedevere-bot mentioned this pull request Aug 15, 2023
Closed
@kamilturek kamilturek changed the title gh-103363: Add follow_symlink argument to pathlib.Path.owner() and group() gh-103363: Add follow_symlinks argument to pathlib.Path.owner() and group() Aug 15, 2023
@kamilturek kamilturek marked this pull request as ready for review August 15, 2023 11:27
@kamilturek kamilturek requested a review from barneygale as a code owner August 15, 2023 11:27
@AA-Turner

This comment was marked as resolved.

Sign in to view
barneygale
barneygale requested changes Nov 26, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me ages to review. Overall looks really good, thank you. Could you merge in the latest main? You'll find there's a new _PathBase class with its own owner() and group() methods - please add the follow_symlinks argument there too. Thanks again!

@bedevere-app
Copy link

bedevere-app bot commented Nov 26, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kamilturek
Copy link
Contributor Author

kamilturek commented Dec 2, 2023

Hey @barneygale. Thanks for the review. That's really appreciated.

I have made the requested changes; please review again

@kamilturek kamilturek requested a review from barneygale December 2, 2023 11:09
@kamilturek
Copy link
Contributor Author

kamilturek commented Dec 2, 2023

I have made the requested changes; please review again

barneygale
barneygale approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashing, thanks so much

@barneygale barneygale merged commit a1551b4 into python:main Dec 4, 2023
@kamilturek kamilturek deleted the gh-103363 branch December 4, 2023 21:14
@kamilturek kamilturek restored the gh-103363 branch December 4, 2023 21:14
@kamilturek kamilturek deleted the gh-103363 branch December 4, 2023 21:14
@kamilturek kamilturek restored the gh-103363 branch December 4, 2023 21:20
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@kamilturek @aisk
pythongh-103363: Add follow_symlinks argument to `pathlib.Path.owner(…
0909269 
…)` and `group()` (python#107962)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@kamilturek @Glyphack
pythongh-103363: Add follow_symlinks argument to `pathlib.Path.owner(…
b0c814f 
…)` and `group()` (python#107962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale barneygale approved these changes

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kamilturek @AA-Turner @barneygale @bedevere-bot