bpo-31784: Use time.time_ns() in uuid.uuid1()#11189
Merged
vstinner merged 2 commits intopython:masterfrom Dec 18, 2018
vstinner:uuid_time_ns
Merged
bpo-31784: Use time.time_ns() in uuid.uuid1()#11189vstinner merged 2 commits intopython:masterfrom vstinner:uuid_time_ns
vstinner merged 2 commits intopython:masterfrom
vstinner:uuid_time_ns
Conversation
uuid.uuid1() now calls time.time_ns() rather than int(time.time() * 1e9). Replace also int(nanoseconds/100) with nanoseconds // 100.
eamanu
reviewed
Dec 17, 2018
| global _last_timestamp | ||
| import time | ||
| nanoseconds = int(time.time() * 1e9) | ||
| nanoseconds = time.time_ns() |
Contributor
There was a problem hiding this comment.
Why int(time.time() * 1e9) == time.time_ns() is False? Must be True, isn't?
Member
Author
There was a problem hiding this comment.
time.time_ns() == time.time_ns() is false because clock changes each time you call it :-)
Contributor
There was a problem hiding this comment.
ho! you are right, I was confused
Member
Author
|
I added an unit test, but I'm not sure if it's worth it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace int(time.time() * 1e9) with time.time_ns().
https://bugs.python.org/issue31784