[3.9] gh-98517: Fix buffer overflows in _sha3 module (GH-98519)#98526
Merged
ambv merged 1 commit intopython:3.9from Oct 28, 2022
Merged
[3.9] gh-98517: Fix buffer overflows in _sha3 module (GH-98519)#98526ambv merged 1 commit intopython:3.9from
ambv merged 1 commit intopython:3.9from
Conversation
…-98519) This is a port of the applicable part of XKCP's fix [1] for CVE-2022-37454 and avoids the segmentation fault and the infinite loop in the test cases published in [2]. [1]: XKCP/XKCP@fdc6fef [2]: https://mouha.be/sha-3-buffer-overflow/ Regression test added by: Gregory P. Smith [Google LLC] <[email protected]> (cherry picked from commit 0e4e058) Co-authored-by: Theo Buehler <[email protected]>
bedevere-bot
added
type-crash
gpshead
approved these changes
Oct 21, 2022
gpshead
changed the title
Contributor
Author
|
Sorry, I can't merge this PR. Reason: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a port of the applicable part of XKCP's fix 1 for
CVE-2022-37454 and avoids the segmentation fault and the infinite
loop in the test cases published in 2.
Regression test added by: Gregory P. Smith [Google LLC] [email protected]
(cherry picked from commit 0e4e058)
Co-authored-by: Theo Buehler [email protected]