Skip to content

RF-35226 remove default tunnel id argument value#496

Merged
sebaherrera07 merged 3 commits into
masterfrom
RF-35226-remove-default-tunnel-id
Aug 1, 2024
Merged

RF-35226 remove default tunnel id argument value#496
sebaherrera07 merged 3 commits into
masterfrom
RF-35226-remove-default-tunnel-id

Conversation

@sebaherrera07

@sebaherrera07 sebaherrera07 commented Jul 30, 2024

Copy link
Copy Markdown
  • Remove the "default" value for the tunnel-id argument for direct connect.
  • Output the connection name to console when the tunnel is established.
  • Add instruction to README to install submodules.
image

@marvin-rfbot

marvin-rfbot Bot commented Jul 30, 2024

Copy link
Copy Markdown

@sebaherrera07 sebaherrera07 changed the title RF-35226 remove default tunnel id argument value [WIP] RF-35226 remove default tunnel id argument value Jul 30, 2024
This value was used when not passing a specific tunnel-id param, but it is not needed anymore.
@sebaherrera07 sebaherrera07 force-pushed the RF-35226-remove-default-tunnel-id branch from cb72368 to 42db471 Compare July 30, 2024 16:22
@sebaherrera07 sebaherrera07 changed the title [WIP] RF-35226 remove default tunnel id argument value RF-35226 remove default tunnel id argument value Aug 1, 2024
@sebaherrera07

Copy link
Copy Markdown
Author

/reviewme @ubergeek42

@marvin-rfbot marvin-rfbot Bot added the review label Aug 1, 2024
@marvin-rfbot marvin-rfbot Bot requested a review from ubergeek42 August 1, 2024 13:46

@ubergeek42 ubergeek42 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the readme!

@sebaherrera07 sebaherrera07 merged commit d5e2a8f into master Aug 1, 2024
@sebaherrera07 sebaherrera07 deleted the RF-35226-remove-default-tunnel-id branch August 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants