Skip to content

Conversation

@Chief-Rishab
Copy link
Member

@Chief-Rishab Chief-Rishab commented May 12, 2023

  • On provider update, code currently doesn't fetch resources. Resource Fetch only happens on provider creation and through fetch resources job. It should ideally happen on provider update also.

  • add information like appeal_id, grant_id wherever possible in slack notifier error logs so that it is easy to debug whenever there's an error, along with what type of notification was being tried when it errored out.

@coveralls
Copy link

coveralls commented May 12, 2023

Pull Request Test Coverage Report for Build 4964950600

  • 56 of 69 (81.16%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 75.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/grant/service.go 15 17 88.24%
plugins/notifiers/slack/client.go 4 6 66.67%
core/provider/service.go 14 17 82.35%
core/appeal/service.go 15 21 71.43%
Totals Coverage Status
Change from base Build 4761564421: 0.03%
Covered Lines: 8006
Relevant Lines: 10630

💛 - Coveralls

@Chief-Rishab Chief-Rishab marked this pull request as ready for review May 13, 2023 03:56
@ravisuhag ravisuhag merged commit 538127b into main May 13, 2023
@ravisuhag ravisuhag deleted the feat/fetch-resources branch May 13, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants