[Php85] Rename deprecated PDO constants and methods#7125
Conversation
|
Thanks. Could you resolve conflicts? |
|
Will do so tomorrow for all of my PHP 8.5 PRs that need conflict resolution. |
config/set/php85.php
Outdated
| $rectorConfig->ruleWithConfiguration( | ||
| RenameClassConstFetchRector::class, | ||
| [ | ||
| new RenameClassAndConstFetch('PDO', 'DBLIB_ATTR_CONNECTION_TIMEOUT', 'Pdo\Dblib', 'ATTR_CONNECTION_TIMEOUT'), |
There was a problem hiding this comment.
downgrade rule is needed for this, to downgrade constant to previous available constant, since the constant exists since php 8.4
You can see example of it
There was a problem hiding this comment.
@samsonasik Does this really need a new rector implementation or can't the inverse RenameClassAndConstFetch config be used in config/set/downgrade-php85.php?
PS: I just saw some other rule sets also using "normal" rector rename rules, thus I will do the same.
There was a problem hiding this comment.
when downgrading code, that exists in old and removed later, or only exists in future php version, the snippet code generate can be used, eg this example
Then use inline code parser to cover that
There was a problem hiding this comment.
@samsonasik Sadly, I can't connect your comment to this PR but I created rectorphp/rector-downgrade-php#304 where we can tackle this discussion and if that solution has issues relating to your example from the previous comment.
There was a problem hiding this comment.
Once code downgraded, the code should keep working even on the future php version is met, eg, downgraded from 8.1 to 8.0, when downgraded code opened in php 8.1, it should keep working.
Php is unfortunatelly not semver, so some tweak for this kind of usage seems needed, like if exists check.
There was a problem hiding this comment.
I am unsure exactly whether rectorphp/rector-downgrade-php#304 meets these requirements. If it does not, someone else should tackle this topic then, please. At this point in time, I do not want to spend my time on writing code to downgrade PHP code.
There was a problem hiding this comment.
It's the same rules, just inverted renames.
mttsch
force-pushed
the
feature/php85-deprecated-pdo-constants-methods
branch
from
fcd5904 to
ff5fe75
Compare
|
Let's merge this as it is, as downgrade of pdo is quite a niche feature. We can keep those separately. Thanks for the feature 👌 |
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
3 participants
No description provided.