[ChangesReporting] Fix total changed result on --no-diffs on JsonOutputFormatter#7807
Merged
TomasVotruba merged 1 commit intomainfrom Jan 5, 2026
Merged
[ChangesReporting] Fix total changed result on --no-diffs on JsonOutputFormatter#7807TomasVotruba merged 1 commit intomainfrom
TomasVotruba merged 1 commit intomainfrom
Conversation
Member
Author
|
Fixed 🎉 /cc @peterfox |
Member
Author
|
@TomasVotruba ready 👍 |
Contributor
|
Amazing @samsonasik I was looking at this, my fix was way more converluted 😄. Thank you so much |
Member
|
LGTM 👍 |
Contributor
|
The only thing I will add is, the way the formatter currently works, you lose the "changed_files" part of the JSON. Some might expect to still see this if the "changed_files": [
"some/file.php"
], |
Member
|
@peterfox Seems legit. Could you make a PR for it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9582
Even with
--no-diffs, the total files changed should still be shown, just no diff to be shown.With a 1 file to be changed, it shows:
Before
➜ rector-src git:(main) ✗ ./bin/rector process src/Application/FileProcessor.php --output-format=json --no-diffs --dry-run { "totals": { "changed_files": 0, "errors": 0 } }After
➜ rector-src git:(fix-total-changed) ./bin/rector process src/Application/FileProcessor.php --output-format=json --no-diffs --dry-run { "totals": { "changed_files": 1, "errors": 0 } }