Bug fix: Incorrect status code on unauthorized access#7785
Merged
NGPixel merged 2 commits intorequarks:mainfrom Sep 24, 2025
Merged
Bug fix: Incorrect status code on unauthorized access#7785NGPixel merged 2 commits intorequarks:mainfrom
NGPixel merged 2 commits intorequarks:mainfrom
Conversation
Contributor
Author
|
@NGPixel I know you're a busy person, but could you review this when you have a moment. I'd like to have this merged in for use in the sites I have wiki.js deployed. |
NGPixel
approved these changes
Sep 24, 2025
Member
|
Thanks |
glalo
pushed a commit
to glalo/wiki
that referenced
this pull request
Oct 3, 2025
* fix status code on unauthorized * Remove unnecessary line breaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to duplicate a page, the operation redirected to an error screen.
Upon investigation, I found that the issue was caused by a missing
read:sourcepermission.In the Network tab of the Developer Tools, I observed that the server returned a 200 status code when the error screen was displayed.
This was misleading, as it indicated a successful response despite the authorization failure.
This pull request updates the relevant section to ensure that the appropriate status code is returned in cases of unauthorized access.
Steps to reproduce:
read:sourcepermission