fix: Stop dompurify from breaking draw.io diagrams#7888
Merged
NGPixel merged 1 commit intorequarks:mainfrom Jan 6, 2026
Merged
fix: Stop dompurify from breaking draw.io diagrams#7888NGPixel merged 1 commit intorequarks:mainfrom
NGPixel merged 1 commit intorequarks:mainfrom
Conversation
Newer versions of dompurify strip <foreignobject> tags if not explicitly allowed. See cure53/DOMPurify#1040 Fixes requarks#7744
Contributor
Author
|
Just found #7843 which also includes this fix (but also adds a new feature). If the other PR is too large / not finished maybe my trivial fix could be merged in the meantime? Otherwise, feel free to close. |
NGPixel
approved these changes
Jan 6, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the regression from wikijs 2.5.307 (see bug report #7744).
Newer versions of dompurify strip
<foreignobject>tags if not explicitly allowed. See cure53/DOMPurify#1040