Conversation
This reverts commits: dc38e99 22c082f b499e0f 58e5876 Add test for overriden private methods [Fixes https://bugs.ruby-lang.org/issues/12136]
marcandre
force-pushed
the
udpate
branch
3 times, most recently
from
2828baa to
66ac661
Compare
|
i have seen ruby making problems when using |
Member
Author
The os = OpenStruct.new
os.respond_to?(:foo) # => false
os.foo # => nilThat's in part because responding to |
eregon
reviewed
Sep 14, 2020
| end | ||
|
|
||
| def test_frozen | ||
| return if RUBY_ENGINE == 'truffleruby' # https://github.com/oracle/truffleruby/issues/2093 |
Member
There was a problem hiding this comment.
Since this has been fixed by @bjfish in truffleruby/truffleruby#2093 and the CI uses truffleruby-head, it should work fine without this change, @marcandre can you try?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on ruby-lang; probably best to discuss this there.