Improve the mise.toml parser to conform to the TOML specification#868
Merged
eregon merged 1 commit intoruby:masterfrom Jan 30, 2026
Merged
Improve the mise.toml parser to conform to the TOML specification#868eregon merged 1 commit intoruby:masterfrom
eregon merged 1 commit intoruby:masterfrom
Conversation
pan93412
force-pushed
the
fix-mise-parser
branch
from
88cc3dd to
e259534
Compare
pan93412
changed the title
pan93412
changed the title
pan93412
force-pushed
the
fix-mise-parser
branch
from
e259534 to
acfd26a
Compare
There was a problem hiding this comment.
Pull request overview
This PR tightens the mise.toml parsing logic in parseRubyEngineAndVersion so that Ruby versions can be read correctly even when the line includes valid TOML end-of-line comments, addressing issue #867.
Changes:
- Updated the
mise.tomlregex to allow leading whitespace, extract the quoted Ruby version, and ignore trailing#comments. - Left the overall control flow of
parseRubyEngineAndVersionunchanged, still selecting.ruby-version,.tool-versions, ormise.tomlbased solely on file existence.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pan93412
force-pushed
the
fix-mise-parser
branch
from
acfd26a to
42d3d52
Compare
Fixed ruby#867 ("mise.toml parser fails when ruby line contains end-of-line comments") Co-authored-by: Riley Ho <riley@rileychh.dev>
pan93412
force-pushed
the
fix-mise-parser
branch
from
42d3d52 to
6ff1e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #867