Skip to content

Enable file locking support for Hurd #150058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Dec 31, 2025
Merged

Enable file locking support for Hurd #150058

bors merged 1 commit into from
Dec 31, 2025

Conversation

@Fabian-Gruenbichler
Copy link
Contributor

@Fabian-Gruenbichler Fabian-Gruenbichler commented Dec 16, 2025 •
edited by rustbot
Loading

like Illumos (#148322) and aix (#148619), Hurd was missed when originally
introducing locking gates per target OS in #132977. building rustc on Hurd was
broken as a result since 1.91.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 16, 2025
@Fabian-Gruenbichler
Copy link
Contributor Author

Fabian-Gruenbichler commented Dec 16, 2025

(marked as draft for now because my test build of 1.91.1 with this backported is still running, and I want to ensure it works as expected end-to-end before it gets merged!)

@workingjubilee
Copy link
Member

workingjubilee commented Dec 16, 2025

Thanks for the fix. This obviously seems fine if it fixes the issue, which you will know better, so, r=me after you verify.

r? @workingjubilee
@bors delegate+

@bors
Copy link
Collaborator

bors commented Dec 16, 2025

✌️ @Fabian-Gruenbichler, you can now approve this pull request!

If @workingjubilee told you to "r=me" after making some further change, please make that change, then do @bors r=@workingjubilee

@Fabian-Gruenbichler Fabian-Gruenbichler marked this pull request as ready for review December 17, 2025 12:52
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 17, 2025
@rustbot

This comment has been minimized.

Sign in to view
@Fabian-Gruenbichler
Copy link
Contributor Author

Fabian-Gruenbichler commented Dec 17, 2025

bors r=@workingjubilee

@Fabian-Gruenbichler
Copy link
Contributor Author

Fabian-Gruenbichler commented Dec 17, 2025

can confirm that building 1.91.1 with a backport of this and --bypass-bootstrap-lock works, and a rebuild using that 1.91.1 build without --bypass-bootstrap-lock works as well, so I would consider this ready for reviewing :)

@workingjubilee
Copy link
Member

workingjubilee commented Dec 25, 2025 •
edited
Loading

@bors delegate-

@Fabian-Gruenbichler Need the @ first, but also please move the issue/PR numbers in the git commit comments into the PR description, as requested by the bot.

( I think GitHub fixed that for notifications but I don't remember if they fixed it for issue pingbacks... )

@workingjubilee
Copy link
Member

workingjubilee commented Dec 25, 2025

whoops, misdescribed what the bot requested. read the text, jubilee!!!

@Fabian-Gruenbichler
Copy link
Contributor Author

Fabian-Gruenbichler commented Dec 26, 2025

sorry, I misread the bot messages as well (both the review and the no issue references ones). will clean this up shortly!

@Fabian-Gruenbichler
Enable file locking support for Hurd
e318527 
like Illumos and AIX, Hurd was missed when originally introducing locking gates
per target OS. building rustc on Hurd was broken as a result since 1.91.

Signed-off-by: Fabian Grünbichler <[email protected]>
@Fabian-Gruenbichler
Copy link
Contributor Author

Fabian-Gruenbichler commented Dec 26, 2025

@bors r=@workingjubilee

@bors
Copy link
Collaborator

bors commented Dec 26, 2025

@Fabian-Gruenbichler: 🔑 Insufficient privileges: Not in reviewers

@workingjubilee
Copy link
Member

workingjubilee commented Dec 30, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 30, 2025

📌 Commit e318527 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2025
@workingjubilee
Copy link
Member

workingjubilee commented Dec 30, 2025

@bors rollup

@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 30, 2025
Merged
bors added a commit that referenced this pull request Dec 30, 2025
@bors
Auto merge of #150526 - JonathanBrouwer:rollup-j9hy7fm, r=JonathanBro…
94f8f40 
…uwer

Rollup of 3 pull requests

Successful merges:

 - #150058 (Enable file locking support for Hurd)
 - #150420 (Do not spill operand debuginfo to stack for AArch64 SVE predicates `<vscale x N x i1>` where `N != 16`)
 - #150501 (Fix Typos in Platform Support Tables)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit de16c1a into rust-lang:main Dec 31, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 31, 2025
rust-timer added a commit that referenced this pull request Dec 31, 2025
@rust-timer
Unrolled build for #150058
5fc1afd 
Rollup merge of #150058 - Fabian-Gruenbichler:main, r=workingjubilee

Enable file locking support for Hurd

like Illumos (#148322) and aix (#148619), Hurd was missed when originally
introducing locking gates per target OS in #132977. building rustc on Hurd was
broken as a result since 1.91.
@bors
Copy link
Collaborator

bors commented Dec 31, 2025

⌛ Testing commit e318527 with merge 94f8f40...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@workingjubilee workingjubilee

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Fabian-Gruenbichler @workingjubilee @bors @rustbot