Skip to content

Conversation

@saethlin
Copy link
Member

No description provided.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2025
@saethlin saethlin force-pushed the dont-prefer-c-builtins branch from 7bfc464 to 368b2ef Compare December 20, 2025 02:23
@saethlin saethlin changed the title Prefer any other crate over c-builtins when selecting an upstream monomorphization Don't export upstream monomorphizations from compiler-builtins Dec 20, 2025
@saethlin
Copy link
Member Author

r? bjorn3

@saethlin saethlin marked this pull request as ready for review December 20, 2025 03:28
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@saethlin
Copy link
Member Author

🤨

r? bjorn3

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

Requested reviewer is already assigned to this pull request.

Please choose another assignee.

@durin42
Copy link
Contributor

durin42 commented Dec 20, 2025

Patched it in and built a toolchain so I could test it on my Mac, and as far as I can tell this does fix the problem. Thanks for a quick fix!

@saethlin saethlin force-pushed the dont-prefer-c-builtins branch from 368b2ef to 44a9d84 Compare December 20, 2025 17:21
@bjorn3
Copy link
Member

bjorn3 commented Dec 23, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 23, 2025

📌 Commit 44a9d84 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 23, 2025
…=bjorn3

Don't export upstream monomorphizations from compiler-builtins
bors added a commit that referenced this pull request Dec 23, 2025
Rollup of 5 pull requests

Successful merges:

 - #150182 (Don't export upstream monomorphizations from compiler-builtins)
 - #150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - #150308 (Update bors configuration)
 - #150311 (Avoid using env::temp when linking a binary)
 - #150314 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 24, 2025
Rollup of 6 pull requests

Successful merges:

 - #149800 (Fix ICE in normalization during closure capture analysis (#149746))
 - #150182 (Don't export upstream monomorphizations from compiler-builtins)
 - #150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - #150308 (Update bors configuration)
 - #150314 (rustc-dev-guide subtree update)
 - #150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6212979 into rust-lang:main Dec 24, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 24, 2025
rust-timer added a commit that referenced this pull request Dec 24, 2025
Rollup merge of #150182 - saethlin:dont-prefer-c-builtins, r=bjorn3

Don't export upstream monomorphizations from compiler-builtins
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 27, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#149800 (Fix ICE in normalization during closure capture analysis (rust-lang/rust#149746))
 - rust-lang/rust#150182 (Don't export upstream monomorphizations from compiler-builtins)
 - rust-lang/rust#150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - rust-lang/rust#150308 (Update bors configuration)
 - rust-lang/rust#150314 (rustc-dev-guide subtree update)
 - rust-lang/rust#150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Dec 29, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#149800 (Fix ICE in normalization during closure capture analysis (rust-lang/rust#149746))
 - rust-lang/rust#150182 (Don't export upstream monomorphizations from compiler-builtins)
 - rust-lang/rust#150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - rust-lang/rust#150308 (Update bors configuration)
 - rust-lang/rust#150314 (rustc-dev-guide subtree update)
 - rust-lang/rust#150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#149800 (Fix ICE in normalization during closure capture analysis (rust-lang/rust#149746))
 - rust-lang/rust#150182 (Don't export upstream monomorphizations from compiler-builtins)
 - rust-lang/rust#150216 (Tidying up tests/ui/issues 15 tests [6/N])
 - rust-lang/rust#150308 (Update bors configuration)
 - rust-lang/rust#150314 (rustc-dev-guide subtree update)
 - rust-lang/rust#150319 (use new term in description of --target)

r? `@ghost`
`@rustbot` modify labels: rollup
@saethlin saethlin deleted the dont-prefer-c-builtins branch January 14, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants