Skip to content

Underscore-prefixed bindings are explicitly allowed to be unused #150955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenyukang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Underscore-prefixed bindings are explicitly allowed to be unused #150955

chenyukang wants to merge 1 commit into from
+34 −0

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 11, 2026 •
edited by rustbot
Loading

Fixes #149889

@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fee1-dead
Copy link
Member

fee1-dead commented Jan 18, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit ea93fb5 has been approved by fee1-dead

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 18, 2026
@jhpratt
Rollup merge of rust-lang#150955 - yukang-fix-149889-unused-assign, r…
d0745c8 
…=fee1-dead

Underscore-prefixed bindings are explicitly allowed to be unused

Fixes rust-lang#149889
@jhpratt jhpratt mentioned this pull request Jan 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-dead fee1-dead

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression unused_assignments for variable with underscore prefix captured by closure

3 participants

@chenyukang @rustbot @fee1-dead