Skip to content

remove trailing periods in built-in attribute gate messages #151279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fee1-dead wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove trailing periods in built-in attribute gate messages #151279

fee1-dead wants to merge 1 commit into from
+11 −11

Conversation

@fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jan 18, 2026

consistency, we do this for all diagnostic texts

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@chenyukang
Copy link
Member

chenyukang commented Jan 18, 2026

@bors r=chenyukang

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 18, 2026

📌 Commit 216ca14 has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jan 18, 2026
@jhpratt
Rollup merge of rust-lang#151279 - push-xzxlnsyqtuoo, r=chenyukang
9ab214a 
remove trailing periods in built-in attribute gate messages

consistency, we do this for all diagnostic texts
@jhpratt jhpratt mentioned this pull request Jan 18, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mati865 mati865

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fee1-dead @rustbot @chenyukang @mati865