PrettyPrint wrapper, custom 'Read' input, bugfixes, major refactoring#936
Merged
Conversation
This was referenced Apr 22, 2020
Owner
Author
|
@dandavison Would an API like this work for |
Contributor
This looks great! However, regarding delta, the only things it uses from bat are the pager spawning code ( |
Owner
Author
|
I see. Than you for the clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a major update of "bat as a library". I have implemented a new
PrettyPrinterstruct which is a builder-like wrapper to configure and control the pretty-printing process. I tried to make it similar toprettyprint::PrettyPrinterby @mre, but it will not be a drop-in replacement, unfortunately.Major new functionality: the
batlibrary can now accept arbitraryReaders as input. This also includes input from a (byte) string.Here are a few examples of how the library can be used (see
examplesfolder for more):simple.rscat.rsyaml.rsadvanced.rscloses #884
closes #937
closes #729
closes #730