Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 222 222
Lines 7501 7501
=======================================
Hits 6823 6823
Misses 678 678 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
LGTM - I'm glad to know more tests are running more often 🙏 ✨
I'm curious if you were thinking about later introducing codecov? The various jobs running makes this seem like an interesting enhancement if so!
| - name: Run tests for HTTP Mode adapters (WSGI) | ||
| run: | | ||
| pytest tests/adapter_tests/wsgi/ |
There was a problem hiding this comment.
This seems to match the other test setups, but I'm wondering if this warning is expected or not?
../../../../../opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/_pytest/config/__init__.py:1441
/opt/hostedtoolcache/Python/3.13.2/x64/lib/python3.13/site-packages/_pytest/config/__init__.py:1441: PytestConfigWarning: Unknown config option: asyncio_mode
self._warn_or_fail_if_strict(f"Unknown config option: {key}\n")
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
🔗 https://github.com/slackapi/bolt-python/actions/runs/13931970838/job/38991049073#step:16:23
There was a problem hiding this comment.
Good catch 💯 we can ignore this warning since it comes from trying to configure pytest-asyncio when it is not installed
| - name: Install all dependencies | ||
| run: | | ||
| pip install -r requirements/testing.txt |
There was a problem hiding this comment.
QQ: Should this be with the "Install all dependencies" job?
It's not super clear to me which steps use which dependencies and TBH I wouldn't be against separating sync from async tests if dependencies are shared in unexpected ways 👾
There was a problem hiding this comment.
Yesss I see what you mean it might be better to do thins in a separate PR 🤔
2 participants
Summary
This PR aims to increase the tests covered by our CI pipeline, this aims to allow dependabot auto merging
Testing
N/A
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.