chore: move dependencies to pyproject.toml#1360
Conversation
WilliamBergamin
added
dependencies
| rm -rf ./slack_bolt.egg-info | ||
|
|
||
| pip install -U pip && \ | ||
| pip install twine build && \ |
There was a problem hiding this comment.
Minor improvements for consistency
| - package-ecosystem: "npm" | ||
| directory: "/docs" | ||
| schedule: | ||
| interval: "monthly" | ||
| groups: | ||
| docusaurus: | ||
| patterns: | ||
| - "@docusaurus/*" | ||
| react: | ||
| patterns: | ||
| - "react" | ||
| - "react-dom" |
There was a problem hiding this comment.
Cleaning this up because we don't need it anymore
There was a problem hiding this comment.
📚 praise: Thanks for catching this!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 222 222
Lines 7512 7512
=======================================
Hits 6836 6836
Misses 676 676 ☔ View full report in Codecov by Sentry. |
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin LGTM! This is such a nice change to keep things fresh 🚢 🫧
| - package-ecosystem: "npm" | ||
| directory: "/docs" | ||
| schedule: | ||
| interval: "monthly" | ||
| groups: | ||
| docusaurus: | ||
| patterns: | ||
| - "@docusaurus/*" | ||
| react: | ||
| patterns: | ||
| - "react" | ||
| - "react-dom" |
There was a problem hiding this comment.
📚 praise: Thanks for catching this!
There was a problem hiding this comment.
🫡 praise: Farewell to requirements.txt indeed.
2 participants
Summary
Python 3.6 did not support the
pip install .command which installs the dependencies of the project, this is why we defined arequirements.txtfile at the top level. Now that this project does not support python 3.6 we can get ride ofrequirements.txtTesting
CI passes
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.