Remove unnecessary shutdown idle timeout configuration from JettyServletWebServerFactoryTests#49278
Closed
l2yujw wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the PR. I wrote the original TODO but, unfortunately, I didn't keep good enough notes as to why it was necessary. Having just experimented a little, it doesn't seem to be necessary any more as all tests in |
6deac01 to
d1def89
Compare
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
d1def89 to
bc019b3
Compare
Contributor
Author
|
Thanks for confirming. Updated as suggested: I removed the main code change and kept the PR focused on the tests by removing the idle timeout configuration (and the related TODO). All tests in JettyServletWebServerFactoryTests still pass. |
wilkinsona
pushed a commit
that referenced
this pull request
Feb 24, 2026
Signed-off-by: l2yuPa <jeungwon28@gmail.com> See gh-49278
Member
|
Thanks very much, @l2yujw. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the Jetty connector shutdown idle timeout configuration from a
test-only customizer into main code when graceful shutdown is enabled.
Rationale
The Jetty servlet web server tests currently set
shutdownIdleTimeoutvia acustomizer and include a TODO to configure it in main code. Keeping this as a
test-only workaround can lead to inconsistent behavior for users relying on
graceful shutdown.
Changes
shutdownIdleTimeoutto JettyServerConnectors whenShutdown.GRACEFULis enabledTesting
./gradlew :module:spring-boot-jetty:test