Skip to content

Remove unnecessary shutdown idle timeout configuration from JettyServletWebServerFactoryTests#49278

Closed
l2yujw wants to merge 1 commit into
spring-projects:mainfrom
l2yujw:fix/jetty-graceful-shutdown-idle-timeout
Closed

Remove unnecessary shutdown idle timeout configuration from JettyServletWebServerFactoryTests#49278
l2yujw wants to merge 1 commit into
spring-projects:mainfrom
l2yujw:fix/jetty-graceful-shutdown-idle-timeout

Conversation

@l2yujw
Copy link
Copy Markdown
Contributor

@l2yujw l2yujw commented Feb 20, 2026

This PR moves the Jetty connector shutdown idle timeout configuration from a
test-only customizer into main code when graceful shutdown is enabled.

Rationale

The Jetty servlet web server tests currently set shutdownIdleTimeout via a
customizer and include a TODO to configure it in main code. Keeping this as a
test-only workaround can lead to inconsistent behavior for users relying on
graceful shutdown.

Changes

  • Apply shutdownIdleTimeout to Jetty ServerConnectors when Shutdown.GRACEFUL is enabled
  • Remove the test customizer and the related TODO

Testing

  • ./gradlew :module:spring-boot-jetty:test

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 20, 2026
@wilkinsona
Copy link
Copy Markdown
Member

Thanks for the PR. I wrote the original TODO but, unfortunately, I didn't keep good enough notes as to why it was necessary. Having just experimented a little, it doesn't seem to be necessary any more as all tests in JettyServletWebServerFactoryTests pass without it. Rather than changing main code, would you like to update your PR to only change the tests and remove the idle timeout configuration?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Feb 23, 2026
@l2yujw l2yujw force-pushed the fix/jetty-graceful-shutdown-idle-timeout branch from 6deac01 to d1def89 Compare February 23, 2026 15:33
Signed-off-by: l2yuPa <jeungwon28@gmail.com>
@l2yujw l2yujw force-pushed the fix/jetty-graceful-shutdown-idle-timeout branch from d1def89 to bc019b3 Compare February 23, 2026 15:34
@l2yujw
Copy link
Copy Markdown
Contributor Author

l2yujw commented Feb 23, 2026

Thanks for confirming. Updated as suggested: I removed the main code change and kept the PR focused on the tests by removing the idle timeout configuration (and the related TODO). All tests in JettyServletWebServerFactoryTests still pass.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 23, 2026
@wilkinsona wilkinsona changed the title Jetty: apply shutdown idle timeout for graceful shutdown Removing unnecessary shutdown idle timeout configuration from JettyServletWebServerFactoryTests Feb 24, 2026
@wilkinsona wilkinsona changed the title Removing unnecessary shutdown idle timeout configuration from JettyServletWebServerFactoryTests Remove unnecessary shutdown idle timeout configuration from JettyServletWebServerFactoryTests Feb 24, 2026
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Feb 24, 2026
@wilkinsona wilkinsona added this to the 3.5.x milestone Feb 24, 2026
@wilkinsona wilkinsona self-assigned this Feb 24, 2026
@wilkinsona wilkinsona modified the milestones: 3.5.x, 3.5.12 Feb 24, 2026
wilkinsona pushed a commit that referenced this pull request Feb 24, 2026
Signed-off-by: l2yuPa <jeungwon28@gmail.com>

See gh-49278
@wilkinsona
Copy link
Copy Markdown
Member

Thanks very much, @l2yujw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task A general task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants