Add more styling support to the Logback and Log4j2 color converters

[mayankvirole]

• Add REVERSE (ANSI code 7) to AnsiStyle enum ,
• Expand ColorConverter ELEMENTS map to include all AnsiStyle values (bold, italic, underline, normal, faint, reverse) and all AnsiBackground colors with the bg_ prefix (bg_red, bg_bright_green, etc.)
• Update tests for both logback and log4j2 converters

Closes #49262

[wilkinsona]

Thanks for the PR, @mayankvirole, but this isn't quite what we're looking for. Phil described this in his comment on the issue:

we'll probably need updates to the converters so that multiple parameters can be passed to the converter. Currently you can only specify one, which gets converted into a single AnsiElement. I think we'll need to support several so that you can set forground/background/style in one hit. We'd then need to add more items to the ELEMENTS map to cover AnsiStyle, AnsiBackground and AnsiColor.

For example, it should be possible to produce output that's both red and underlined (\e[4;31mRed and underlined\e[0m).

Would you like to refine your proposal to support using style, background, and color in combination?

[mayankvirole]

Yes , allow me some time to refactor the code

[mayankvirole]

I have refined my approach , please review it at your convenience.

[wilkinsona]

Thanks for the updates, @mayankvirole. I'd like to discuss this one with the rest of the team. With the support for styling (and not just foreground and background colours), the ColorConverter class names are no longer an ideal fit. Perhaps more importantly the clr keyword also doesn't fit quite so well. I'm wondering if we need to rename things or perhaps introduce the new capabilities in a new converter with a new keyword and deprecate the old.

[wilkinsona]

We discussed this today and we're going to stick with the Color… class names and clr keyword as the primary purpose is still to change the text colour with the styling being additions on top of that.

[mayankvirole]

Sounds good, thanks for the update! Let me know if there's anything else you need me to change

[wilkinsona]

Thanks very much, @mayankvirole.