Skip to content

Introduce EnableEnversRepositories meta-annotation#290

Closed
mp911de wants to merge 3 commits into
masterfrom
issue/289
Closed

Introduce EnableEnversRepositories meta-annotation#290
mp911de wants to merge 3 commits into
masterfrom
issue/289

Conversation

@mp911de
Copy link
Copy Markdown
Member

@mp911de mp911de commented Mar 31, 2021

We now provide a composed annotation to enable Envers repositories without the need to specify a custom repository base class.

Closes #289

@mp911de mp911de requested a review from schauder March 31, 2021 07:22
@mp911de mp911de requested a review from odrotbohm March 31, 2021 07:22
@mp911de mp911de added the type: enhancement A general enhancement label Mar 31, 2021
@odrotbohm
Copy link
Copy Markdown
Member

LGTM!

@scordio
Copy link
Copy Markdown
Contributor

scordio commented Mar 31, 2021

Hi @mp911de, would it be an option to also cover what is described in #4 (comment), i.e., exposing an optional configuration to customize the revision entity class?

@mp911de
Copy link
Copy Markdown
Member Author

mp911de commented Mar 31, 2021

Introducing envers-specific property values would require a whole lot more to make this work including an envers-specific EnversRepositoryConfigExtension subclassing JpaRepositoryConfigExtension. Config extensions were never meant to be public in the first place.

Right now we can get away with a composed annotation that overrides the repository bean factory class.

mp911de added 2 commits March 31, 2021 09:53
We now provide a composed annotation to enable envers repositories without the need to specify a custom repository base class.

Closes #289
schauder pushed a commit that referenced this pull request Mar 31, 2021
We now provide a composed annotation to enable Envers repositories without the need to specify a custom repository base class.

Closes #289
Original pull request #290
schauder pushed a commit that referenced this pull request Mar 31, 2021
See #289
Original pull request #290
@schauder
Copy link
Copy Markdown
Contributor

Thanks Mark. That's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate @EnableEnversRepositories meta-annotation

5 participants