Skip to content

Pass env variables to frontend#143

Merged
smacker merged 1 commit into
src-d:masterfrom
smacker:env_vars_in_fe
Feb 21, 2018
Merged

Pass env variables to frontend#143
smacker merged 1 commit into
src-d:masterfrom
smacker:env_vars_in_fe

Conversation

@smacker

@smacker smacker commented Feb 20, 2018

Copy link
Copy Markdown
Contributor

These changes allow to pass environmental variables to frontend.

  • It makes images more flexible (we don't set server URL inside image anymore)
  • We can change frontend behavior depends on environment now
  • Server can pass initial state to frontend if needed

@smacker smacker requested a review from bzz February 20, 2018 15:06
Signed-off-by: Maxim Sukharev <maxim@sourced.tech>

@carlosms carlosms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzz bzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This also should enable flexible GA token passage to FE in #140

@smacker smacker merged commit 7556d94 into src-d:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants