[5.x] Make asset GraphQL type always nullable #11975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11974.
When a user deletes an asset via the asset browser, it can lead to an asset field becoming null even though it is required by its blueprint. This creates a 500 error in the GraphQL endpoint and brings the entire page down.
This PR is a suggestion for a quick and easy fix by just making asset fields always nullable, regardless of whether they are set as
requiredin their blueprint. Within the Control Panel, the field continues to be required, but as the asset deletion logic is able to squeeze a null into the asset field, its GraphQL type should be nullable.