[5.x] Revert "AssetContainer::accessible() should take filesystem visibility into account"
#13673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isibilit…" This reverts commit c53fbc1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #13621.
The
visibilityoption doesn't reliably indicate whether assets are web-accessible. It controls filesystem permissions (local) or object ACLs (S3), but doesn't account for setups where access is provided through other means (eg. a private S3 bucket frontend by CloudFront).The presence of a configured URL is a clearer signal of intent: if a URL is configured, then we know the assets are accessible there, regardless of how that access is achieved.
Fixes #13667.