fix: generate help for recursive custom types#1593
Merged
Conversation
Initial minimal failing example
Contributor
|
Before: After: |
d226ed1 to
95a110e
Compare
fnando
reviewed
Nov 18, 2025
d5f4bce to
67110fd
Compare
Co-authored-by: Nando Vieira <me@fnando.com>
67110fd to
e619aa9
Compare
Contributor
mootz12
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1588
Initial minimal failing example. Looking into it, the fix is that we need to change the way the help generates types and their examples. Currently it assumes that types aren't self referential, hence when generating the enum cases it keeps recursing.
So one solution is to create a types table and perhaps use a stack instead. Either way this is a bigger change than I had initially hoped.