Replace custom data_into_key with to_key method#2301
Merged
Conversation
fnando
approved these changes
Nov 21, 2025
Member
fnando
left a comment
fnando
left a comment
There was a problem hiding this comment.
90 lines out, 4 lines in. Love it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the custom data_into_key function with LedgerEntry's built-in to_key method and remove the 86-line helper function along with its associated imports.
Why
The stellar-xdr library now provides a native to_key method on LedgerEntry, eliminating the need for a custom implementation that manually converts each LedgerEntryData variant to its corresponding LedgerKey.