Skip to content

Properly report when funding accounts fail.#2320

Merged
fnando merged 2 commits into
mainfrom
fix-account-fund-error-report
Dec 8, 2025
Merged

Properly report when funding accounts fail.#2320
fnando merged 2 commits into
mainfrom
fix-account-fund-error-report

Conversation

@fnando
Copy link
Copy Markdown
Member

@fnando fnando commented Dec 8, 2025

What

$ stellar keys generate $RANDOM --network local --fund
✅ Key saved with alias 4610 in "/Users/fnando/.config/stellar/identity/4610.toml"
❌ Unable to fund account 4610 on "Standalone Network ; February 2017"

$ stellar keys generate $RANDOM --network local --fund --very-verbose
2025-12-08T18:50:30.255291Z DEBUG soroban_cli::upgrade_check: start upgrade check
2025-12-08T18:50:30.255549Z DEBUG soroban_cli::upgrade_check: finished upgrade check
✅ Key saved with alias 19251 in "/Users/fnando/.config/stellar/identity/19251.toml"
2025-12-08T18:50:30.279591Z DEBUG soroban_cli::config::network: address "GB7HCF67YBKYHV4FNWGHLC4HBADOAD24KNJGEOGSYBC2BRDQXX5XFCS7"
2025-12-08T18:50:30.279687Z DEBUG soroban_cli::config::network: URL Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("localhost")), port: Some(8000), path: "/friendbot", query: Some("addr=GB7HCF67YBKYHV4FNWGHLC4HBADOAD24KNJGEOGSYBC2BRDQXX5XFCS7"), fragment: None }
2025-12-08T18:50:30.282583Z TRACE soroban_cli::commands::keys::generate: Account funding error: HttpClient(reqwest::Error { kind: Request, url: "http://localhost:8000/friendbot?addr=GB7HCF67YBKYHV4FNWGHLC4HBADOAD24KNJGEOGSYBC2BRDQXX5XFCS7", source: hyper_util::client::legacy::Error(Connect, ConnectError("tcp connect error", [::1]:8000, Os { code: 61, kind: ConnectionRefused, message: "Connection refused" })) })
❌ Unable to fund account 19251 on "Standalone Network ; February 2017"

Why

Close #2319

Known limitations

stellar keys fund already reports errors.

$ stellar keys fund 4610 --network local
❌ error: error sending request for url (http://localhost:8000/friendbot?addr=GDK7Y5ZE7B6EFVQZBAACT67RP3YDAVYWY7XB4PJZ6PU3EEFRWWVJCV5S)

@fnando fnando self-assigned this Dec 8, 2025
@fnando fnando added this to DevX Dec 8, 2025
@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Dec 8, 2025
@fnando fnando moved this from Backlog (Not Ready) to Needs Review in DevX Dec 8, 2025
@fnando fnando enabled auto-merge (squash) December 8, 2025 19:03
@fnando fnando merged commit 861af9b into main Dec 8, 2025
28 of 29 checks passed
@fnando fnando deleted the fix-account-fund-error-report branch December 8, 2025 19:10
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in DevX Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

stellar keys generate --fund report key as funded, even when it fails

2 participants