Embed strkey CLI command for encoding and decoding address strings#2324
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new strkey subcommand to the Stellar CLI by upgrading the stellar-strkey dependency from version 0.0.13 to 0.0.15 and enabling its CLI feature. The implementation follows the existing pattern used for the xdr command, exposing strkey encoding and decoding functionality directly in the CLI for advanced use cases where users need to extract components from Stellar address strings.
Key Changes
- Upgraded stellar-strkey from 0.0.13 to 0.0.15 in workspace dependencies
- Enabled the "cli" feature for stellar-strkey dependency in soroban-cli
- Integrated strkey CLI command as a top-level subcommand alongside existing commands like xdr, contract, keys, etc.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.toml | Updates stellar-strkey version from 0.0.13 to 0.0.15 in workspace dependencies |
| cmd/soroban-cli/Cargo.toml | Enables the "cli" feature for stellar-strkey dependency |
| cmd/soroban-cli/src/commands/mod.rs | Adds Strkey enum variant to Cmd, integrates strkey.run() in match statement, and adds Strkey error variant to Error enum |
fnando
approved these changes
Dec 11, 2025
elizabethengelman
pushed a commit
that referenced
this pull request
Dec 12, 2025
…2324) ### What Upgrade stellar-strkey from 0.0.13 to 0.0.15, enable the cli feature, and add a new `strkey` subcommand to the CLI. ### Why Expose strkey encoding and decoding functionality directly in the CLI, matching the existing pattern used for XDR. For advanced use cases it is helpful to be able to extract components out of addresses. The use cases this is most relevant is cross-chain protocols who prefer to work with the raw payloads within the addresses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Upgrade stellar-strkey from 0.0.13 to 0.0.15, enable the cli feature, and add a new
strkeysubcommand to the CLI.Why
Expose strkey encoding and decoding functionality directly in the CLI, matching the existing pattern used for XDR. For advanced use cases it is helpful to be able to extract components out of addresses. The use cases this is most relevant is cross-chain protocols who prefer to work with the raw payloads within the addresses.