Wrap large fee transactions with fee bump transaction#2382
Merged
Conversation
mootz12
commented
Feb 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds automatic fee-bump wrapping support to Soroban transaction submission flows so transactions with total fees exceeding u32::MAX can still be signed and sent, and surfaces a user warning during tx simulate when a fee bump would be required.
Changes:
- Introduces a shared
sim_sign_and_send_txhelper to centralize simulate → assemble → sign → send logic across multiple commands. - Updates assembly/signing to support fee-bump envelopes when required (fee >
u32::MAX), including hashing/signing fee-bump transactions. - Reorganizes and extends integration tests around fee behavior, including validating fee-bump usage.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/soroban-cli/src/utils.rs | Adds fee bump transaction hashing helper for signing. |
| cmd/soroban-cli/src/tx.rs | Adds sim_sign_and_send_tx helper; wraps signed tx in fee bump when needed. |
| cmd/soroban-cli/src/signer/mod.rs | Adds signing support for fee bump envelopes and refactors signing logic. |
| cmd/soroban-cli/src/resources.rs | Expands allowable --resource-fee range to i64-scale values. |
| cmd/soroban-cli/src/config/mod.rs | Adds sign_fee_bump for fee bump envelope signing. |
| cmd/soroban-cli/src/commands/tx/simulate.rs | Emits warning when simulation indicates a fee bump is needed. |
| cmd/soroban-cli/src/commands/contract/{upload,restore,invoke,extend}.rs | Switches to shared sim/sign/send helper. |
| cmd/soroban-cli/src/commands/contract/deploy/{asset,wasm}.rs | Switches to shared sim/sign/send helper. |
| cmd/soroban-cli/src/assembled.rs | Tracks required fee-bump fee and sets inner tx fee to 0 when overflow; updates unit tests accordingly. |
| cmd/crates/soroban-test/tests/it/integration/fees.rs | Consolidates fee-related integration tests and adds fee bump coverage. |
| cmd/crates/soroban-test/tests/it/integration/fee_stats.rs | Removes standalone fee stats integration test file (moved into fees.rs). |
| cmd/crates/soroban-test/tests/it/integration.rs | Updates integration module list to use consolidated fees module. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fnando
reviewed
Feb 10, 2026
fnando
reviewed
Feb 12, 2026
fnando
reviewed
Feb 20, 2026
Co-authored-by: Nando Vieira <me@fnando.com>
fnando
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
u32::MAXtx simulateif transaction needs a fee bump transactionOutput for fee bump transaction during
invokeand other Soroban commands:Output for simulation that exceeds
u32::MAX:For the logging update, here is a standard
invokecommand:And the
deployfrom WASM file command:Why
Closes #2314
Known limitations
uploadwhen attempting to sign soroban auth entries. Going to address this is a follow-up PR, but I think it is OK as is.