Remove soroban-spec-json crate#2396
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated soroban-spec-json crate and the stellar contract bindings json subcommand, which has been superseded by stellar contract info interface --output json. The removed functionality was incomplete (EventV0 support triggered a todo!() panic) and unused.
Changes:
- Deleted the entire
soroban-spec-jsoncrate including lib.rs, types.rs, README.md, and Cargo.toml - Removed the json command implementation from cmd/soroban-cli/src/commands/contract/bindings/json.rs
- Removed Json enum variants, error types, and command execution from bindings.rs
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/soroban-cli/src/commands/contract/bindings/json.rs | Deleted json bindings command implementation |
| cmd/soroban-cli/src/commands/contract/bindings.rs | Removed Json command variant, error type, and execution logic from enums and match statements |
| cmd/crates/soroban-spec-json/src/types.rs | Deleted type definitions for JSON spec generation |
| cmd/crates/soroban-spec-json/src/lib.rs | Deleted main library implementation with generation functions |
| cmd/crates/soroban-spec-json/README.md | Deleted crate documentation |
| cmd/crates/soroban-spec-json/Cargo.toml | Deleted crate manifest |
| Cargo.toml | Removed soroban-spec-json workspace dependency declaration |
mootz12
approved these changes
Feb 17, 2026
fnando
added a commit
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the
soroban-spec-jsoncrate and thestellar contract bindings jsonsubcommand, including all associated error types and CLI wiring.Why
The JSON bindings were an early attempt to provide contract interfaces in JSON that is no longer needed. The crate doesn't support events (
EventV0triggers atodo!()panic), and the lack of any complaints about this broken behavior confirms it's unused. Thestellar contract bindings jsoncommand has been superseded bystellar contract info interface, which provides an XDR-JSON version of the specification that is up to date, supports events, and is the intended method to get a JSON representation of the spec.