feat: allow stellar key secrets to be input via pipe#2403
Merged
Conversation
leighmcculloch
approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for piping secret keys via stdin to the stellar keys add command, enabling better integration with CI/CD pipelines and automated workflows. The implementation uses Rust's IsTerminal trait to detect whether stdin is a terminal and branches between interactive prompting and non-interactive stdin reading accordingly.
Changes:
- Modified
read_passwordfunction to detect terminal vs non-interactive mode and read from stdin when piped - Added integration test to verify secret keys can be successfully added via stdin
- Cargo.lock updated with removal of
soroban-spec-jsondependency
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/soroban-cli/src/commands/keys/add.rs | Adds terminal detection and stdin reading logic to read_password function to support piped input |
| cmd/crates/soroban-test/tests/it/config.rs | Adds integration test verifying secret keys can be added via stdin piping |
| Cargo.lock | Removes soroban-spec-json package dependency (appears unrelated to main feature) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow secret keys to be input via a pipe.
Example:
Why
Better support for CI environments to safely create keys with the CLI.
Closes: #2388
Known limitations
None