Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the stellar ledger entry fetch trustline --asset command that rejected valid asset codes that weren't exactly 4 or 12 characters long. The fix delegates asset code parsing to the AssetCode type's parse() method from the stellar-xdr library, which properly handles asset codes of any valid length (1-12 characters) and automatically determines whether to use CreditAlphanum4 (1-4 chars) or CreditAlphanum12 (5-12 chars) with proper padding.
Changes:
- Replaced manual length matching logic with
AssetCode::parse()for more flexible asset code validation - Removed unnecessary imports (
TryFromSliceError,AssetCode4,AssetCode12) since they're no longer needed - Simplified the code by delegating validation and type selection to the stellar-xdr library
leighmcculloch
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix trustline --asset to accept valid asset codes of any length.
Why
So it can accept any valid asset length. Close #2395.
Known limitations
N/A