Set more restrictive permission when creating the config directory and key files on unix.#2415
Merged
Conversation
fnando
requested review from
leighmcculloch and
mootz12
and removed request for
Copilot
leighmcculloch
approved these changes
Feb 26, 2026
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
Looks good to me. Some things to consider inline which would make it more secure.
fnando
force-pushed
the
change-permissions
branch
from
25e28fb to
2c35918
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens filesystem permissions on Unix to better protect the CLI’s on-disk configuration by ensuring newly created config directories and key files are owner-only.
Changes:
- Create config directories with
0700on Unix viaDirBuilderExt::mode. - Create key TOML files with
0600on Unix viaOpenOptionsExt::mode. - Add Unix-only tests asserting directory/file modes.
fnando
force-pushed
the
change-permissions
branch
from
3cadb77 to
3830efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
As the title describes it.
Why
So config dir and key files are visible only to the owner.
Known limitations
Windows doesn't have something similar that's easily appliable (we may be able to use ACLs, but it's way more complex).