Hide rpc headers when list networks with stellar network ls --long.#2441
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the stellar network ls --long output to avoid leaking RPC header values by concealing them in the long listing, addressing the reported security issue.
Changes:
- Update
network ls --longformatting to print RPC URL, passphrase, and RPC header names while concealing header values. - Improve long listing readability by separating entries with a blank line.
- Add integration tests ensuring RPC header values are not printed and that “not set” is shown when no headers exist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/soroban-cli/src/commands/network/ls.rs | Reworks long network listing output to conceal RPC header values and adjusts entry separators. |
| cmd/crates/soroban-test/tests/it/integration/network.rs | Adds integration tests to validate concealed header output and “not set” behavior. |
leighmcculloch
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
https://hackerone.com/reports/3596218
Known limitations
N/A