Skip to content

fix (enhanced-img): the basePixels bug#16091

Merged
teemingc merged 3 commits into
sveltejs:mainfrom
blt-r:enhanced_img_bugfix
Jun 19, 2026
Merged

fix (enhanced-img): the basePixels bug#16091
teemingc merged 3 commits into
sveltejs:mainfrom
blt-r:enhanced_img_bugfix

Conversation

@blt-r

@blt-r blt-r commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fix the bug where basePixels is now always emitted in the pixel-density case even when the user supplies an explicit w

fixes this bug #16086 (review) introduced in #15354


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

where basePixels is now always emitted in the pixel-density case even when the user supplies an explicit w
@changeset-bot

changeset-bot Bot commented Jun 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d10dcd3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread packages/enhanced-img/src/index.js Outdated
Comment thread packages/enhanced-img/src/index.js Outdated

@teemingc teemingc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teemingc teemingc merged commit 5a9b7f3 into sveltejs:main Jun 19, 2026
22 of 23 checks passed
@blt-r blt-r deleted the enhanced_img_bugfix branch June 19, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants