Skip to content

Fixing ODF DOM element cloning#314

Merged
mistmist merged 1 commit into
masterfrom
cloning
Jul 30, 2024
Merged

Fixing ODF DOM element cloning#314
mistmist merged 1 commit into
masterfrom
cloning

Conversation

@svanteschubert

@svanteschubert svanteschubert commented Jul 29, 2024

Copy link
Copy Markdown
Contributor

Fixes #313 - OdfElement cloneNode omitted wrongly some ODF attribute for cloning

@svanteschubert svanteschubert requested a review from mistmist July 29, 2024 19:59
@svanteschubert svanteschubert self-assigned this Jul 29, 2024
@svanteschubert svanteschubert linked an issue Jul 29, 2024 that may be closed by this pull request
Create a full copy of a spreadsheet in an ODF Spreadsheet document using the ODF Toolkit. #313
Closed
@svanteschubert

svanteschubert commented Jul 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

PS: How the problem/solution became apparent:
I have opened the content.xml of the output document and compared the two tables (original and cloned) and realized that the @office:value-type="float" was missing in the cloned table.
Therefore in the various office applications the default type string was applied and the content was left aligned (as all strings) contrary to the numbers on the right side.

@mistmist mistmist merged commit 02e6bbf into master Jul 30, 2024
@mistmist mistmist deleted the cloning branch July 30, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistmist mistmist mistmist approved these changes

Assignees

@svanteschubert svanteschubert

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a full copy of a spreadsheet in an ODF Spreadsheet document using the ODF Toolkit.

2 participants

@svanteschubert @mistmist