Skip to content

Additional comment/post page improvements#1945

Merged
hjiangsu merged 2 commits intodevelopfrom
feat/additional-comment-changes
Sep 8, 2025
Merged

Additional comment/post page improvements#1945
hjiangsu merged 2 commits intodevelopfrom
feat/additional-comment-changes

Conversation

@hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Sep 8, 2025

Pull Request Description

This PR applies some additional improvements to the comment and post pages:

  • Cleaned up CommentNode and its related tests.
  • Fixed an issue where the comment bottom sheet modal did not show the general comment submenu when not logged in.
  • Extracted the end-of-feed logic into a new widget, _PostPageFeedEnd, which only renders once the user scrolls to the bottom of the page.
  • Improved scrolling performance on the post page by debouncing UpdateScrollPosition events and skipping markdown semantics when accessibility features are disabled.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu merged commit 77e9a06 into develop Sep 8, 2025
1 check passed
@hjiangsu hjiangsu deleted the feat/additional-comment-changes branch September 8, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant