Fix settings search elevation#1977
Merged
hjiangsu merged 1 commit intothunder-app:developfrom Nov 24, 2025
Merged
Conversation
ggichure
approved these changes
Nov 13, 2025
Member
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Hey, I'm popping back in! 😊 I noticed that the search widget on the settings page has an elevation now. I'm not sure if the change was intentional, but it no longer matches the search page. It looks like the change was lost when the structure was reorganized (https://github.com/thunder-app/thunder/pull/1924/files#diff-70c4cf2c8269388c5f6753ba0c9b01e972187c04800f701e7cd9dd0494e67b31L69).
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
After
Checklist
semanticLabels where applicable for accessibility?