Skip to content

feat: Enable usage of pnpm >5#13344

Merged
caalador merged 4 commits into
masterfrom
issues/12953_allow-newer-pnpm
Mar 25, 2022
Merged

feat: Enable usage of pnpm >5#13344
caalador merged 4 commits into
masterfrom
issues/12953_allow-newer-pnpm

Conversation

@caalador
Copy link
Copy Markdown
Contributor

Allow usage of pnpm 6 by
then generating .pnpmfile.cjs
instead of pnpmfile.js

Closes #12953

Allow usage of pnpm 6 by
then generating `.pnpmfile.cjs`
instead of `pnpmfile.js`

Closes #12953
@caalador caalador force-pushed the issues/12953_allow-newer-pnpm branch from 586b3e4 to b3006b3 Compare March 23, 2022 12:35
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2022

Unit Test Results

   954 files  ±0     954 suites  ±0   51m 20s ⏱️ + 6m 3s
6 179 tests ±0  6 130 ✔️  - 1  49 💤 +1  0 ±0 
6 399 runs  +1  6 344 ✔️ ±0  55 💤 +1  0 ±0 

Results for commit 605b1cb. ± Comparison against base commit 8ea3378.

♻️ This comment has been updated with latest results.

Comment thread flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendTools.java Outdated
caalador and others added 2 commits March 23, 2022 15:01
Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>
Comment thread flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskRunNpmInstall.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@caalador caalador merged commit 8e0351c into master Mar 25, 2022
@caalador caalador deleted the issues/12953_allow-newer-pnpm branch March 25, 2022 08:11
@vaadin-bot
Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 23.1.0.alpha1 and is also targeting the upcoming stable 23.1.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npx pnpm@5.18.10 executes pnpm 6 in some cases

3 participants