Skip to content

feat(geolocation): add addPositionListener to GeolocationTracker#24268

Merged
mcollovati merged 2 commits into
mainfrom
geo-listener
May 6, 2026
Merged

feat(geolocation): add addPositionListener to GeolocationTracker#24268
mcollovati merged 2 commits into
mainfrom
geo-listener

Conversation

@Artur-
Copy link
Copy Markdown
Member

@Artur- Artur- commented May 6, 2026

Lets callers subscribe to tracking updates with plain callbacks instead of subscribing to valueSignal(), mirroring the W3C watchPosition(success, error) pair. Listeners persist across stop()/resume() cycles and never see the GeolocationPending state.

Lets callers subscribe to tracking updates with plain callbacks instead
of subscribing to valueSignal(), mirroring the W3C
watchPosition(success, error) pair. Listeners persist across
stop()/resume() cycles and never see the GeolocationPending state.
@github-actions github-actions Bot added the +0.0.1 label May 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Test Results

 1 397 files  ±0   1 397 suites  ±0   1h 15m 37s ⏱️ +57s
10 099 tests +4  10 029 ✅ +4  70 💤 ±0  0 ❌ ±0 
10 574 runs  +4  10 495 ✅ +4  79 💤 ±0  0 ❌ ±0 

Results for commit 9490c8b. ± Comparison against base commit 81e9281.

♻️ This comment has been updated with latest results.

Verifies the documented "Listeners survive stop()/resume() cycles"
contract on GeolocationTracker.addPositionListener.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

@mcollovati mcollovati enabled auto-merge May 6, 2026 06:43
@mcollovati mcollovati added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 96d8802 May 6, 2026
31 checks passed
@mcollovati mcollovati deleted the geo-listener branch May 6, 2026 07:03
@vaadin-bot
Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.2.0-alpha6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants