fix: clear repeatable read transaction before running access tasks (#24400) (CP: 25.1)#24426
Merged
Merged
Conversation
…24400) ## Summary - Clear the session-scoped transaction **before** running pending access tasks during session unlock - This ensures effects triggered by access tasks see fresh signal values instead of stale cached values from the repeatable read transaction - Added a unit test to verify that clearing the transaction fallback allows fresh reads ## Details When a shared signal is updated concurrently with an ongoing UIDL request, effects associated with that UI would run with the repeatable read transaction used for the request. If the transaction cached the old value, effects would miss the update. The fix moves `sessionScopedTransaction = null` to execute before `runPendingAccessTasks()` instead of after, ensuring access tasks read fresh values. ## Test plan - [ ] Existing unit tests pass - [ ] New `clearingFallback_allowsFreshReads` test verifies the fix behavior - [ ] Manual test with the reproduction case from the issue Fixes #24399 Slack thread: https://vaadin.slack.com/archives/C6RAXJATF/p1779368249043829?thread_ts=1779368185.339629&cid=C6RAXJATF https://claude.ai/code/session_01QW3F8K4uxGyaUNa9xwoKTR --- _Generated by [Claude Code](https://claude.ai/code/session_01QW3F8K4uxGyaUNa9xwoKTR)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
|
vaadin-review-bot
approved these changes
May 22, 2026
Collaborator
Author
|
This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks changes from the original PR #24400 to branch 25.1.
Original PR description